Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CAPI paused annotation #251

Closed
prksu opened this issue Mar 24, 2021 · 3 comments
Closed

Support CAPI paused annotation #251

prksu opened this issue Mar 24, 2021 · 3 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@prksu
Copy link
Contributor

prksu commented Mar 24, 2021

This is a missing feature that we should add starting from v1alpha3 types.

I just tried to do bootstrap & pivot and found an issue that the DOCluster controller doesn't pause the reconciliation with the result that the controller creates a new DOCluster component eg: apiserver LB.

We need to support the cluster.x-k8s.io/paused annotation and Cluster.Spec.Paused field so cluster-api-do will work correctly when pivoting management cluster through clusterctl move.

ref: https://cluster-api.sigs.k8s.io/developer/providers/v1alpha2-to-v1alpha3.html#support-the-clusterx-k8siopaused-annotation-and-clusterspecpaused-field

/kind bug
/milestone v0.4.3

@k8s-ci-robot k8s-ci-robot added this to the v0.4.3 milestone Mar 24, 2021
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 24, 2021
@prksu
Copy link
Contributor Author

prksu commented Mar 25, 2021

/assign

@prksu
Copy link
Contributor Author

prksu commented Mar 29, 2021

/close

@k8s-ci-robot
Copy link

@prksu: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants