Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golang-ci lint configuration exclude configuration #258

Closed
sbueringer opened this issue May 25, 2021 · 3 comments · Fixed by #269
Closed

Fix golang-ci lint configuration exclude configuration #258

sbueringer opened this issue May 25, 2021 · 3 comments · Fixed by #269
Assignees

Comments

@sbueringer
Copy link
Member

The exclude configuration Using the variable on range scope (tc)|(rt)|(tt)|(test)|(testcase)|(testCase) in function literal in .golang.ci.yml matches too many findings.

Every finding which contains "rt", "tt", "test", .. is excluded.

For more context:

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2021
@timoreimann
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 23, 2021
@cpanato
Copy link
Member

cpanato commented Aug 23, 2021

did not see this issue, will work on that

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants