Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capdo/branch: remove master branch reference #22513

Merged
merged 1 commit into from
Jun 11, 2021
Merged

capdo/branch: remove master branch reference #22513

merged 1 commit into from
Jun 11, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 10, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2021
@cpanato
Copy link
Member Author

cpanato commented Jun 10, 2021

/assign @dims for the image-push review

prksu
prksu approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@prksu prksu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@dims
Copy link
Member

dims commented Jun 10, 2021

/approve
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
BenTheElder
BenTheElder approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cpanato, dims, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Jun 11, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit b0db788 into kubernetes:master Jun 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 11, 2021
@k8s-ci-robot
Copy link
Contributor

@cpanato: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-cluster-api.yaml using file config/jobs/image-pushing/k8s-staging-cluster-api.yaml
  • key cluster-api-provider-digitalocean-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-digitalocean/cluster-api-provider-digitalocean-presubmits.yaml

In response to this:

Branch renamed for https://github.com/kubernetes-sigs/cluster-api-provider-digitalocean to main

cleaning up the master reference from the jobs

Fixes: kubernetes-sigs/cluster-api-provider-digitalocean#261

/assign @timoreimann @prksu @MorrisLaw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato deleted the capdo-branch-rename-part-II branch June 11, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@prksu prksu prksu approved these changes

@MorrisLaw MorrisLaw Awaiting requested review from MorrisLaw

Assignees

@dims dims

@timoreimann timoreimann

@BenTheElder BenTheElder

@MorrisLaw MorrisLaw

@prksu prksu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Branch rename master -> main
7 participants
@cpanato @dims @k8s-ci-robot @BenTheElder @prksu @timoreimann @MorrisLaw