Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider if to align manager flag names with upstream Kubernetes components #303

Closed
fabriziopandini opened this issue Feb 16, 2022 · 1 comment · Fixed by #304
Closed
Assignees

Comments

@fabriziopandini
Copy link
Member

While working on adding support for Prometheus in CAPI TiltFile we noticed that latest CAPDO is still using old flags name for metrics and leader election (see
https://cluster-api.sigs.k8s.io/developer/providers/v0.3-to-v0.4.html#align-manager-flag-names-with-upstream-kubernetes-components).

Even this is not mandatory, I suggest the CAPDO team to consider aligning flag names for sake of consistency across providers; also deploying Prometheus in local dev env using the CAPI Tiltfile won't work without this change as well as "--metrics-bind-addr=127.0.0.1:8080" in your manager.yaml file suggested in the same doc linked above.

@cpanato
Copy link
Member

cpanato commented Feb 17, 2022

oh! I thought I change that in the v1beta upgrade, I will fix that @fabriziopandini it is my fault

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants