Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align manager flag names with upstream Kubernetes components and add other flags #304

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 17, 2022

What this PR does / why we need it:

  • align manager flag names with upstream Kubernetes components and add other flags

/kind cleanup
/kind feature

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #303

Special notes for your reviewer:

Documentation:

Release note:

align manager flag names with upstream Kubernetes components and add other flags

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 17, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2022

/test ls

@k8s-ci-robot
Copy link

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-digitalocean-build
  • /test pull-cluster-api-provider-digitalocean-e2e
  • /test pull-cluster-api-provider-digitalocean-lint
  • /test pull-cluster-api-provider-digitalocean-test
  • /test pull-cluster-api-provider-digitalocean-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-digitalocean-capi-e2e
  • /test pull-cluster-api-provider-digitalocean-capi-e2e-experimental
  • /test pull-cluster-api-provider-digitalocean-conformance

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-digitalocean-build
  • pull-cluster-api-provider-digitalocean-e2e
  • pull-cluster-api-provider-digitalocean-lint
  • pull-cluster-api-provider-digitalocean-test
  • pull-cluster-api-provider-digitalocean-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2022

/test pull-cluster-api-provider-digitalocean-capi-e2e
/test pull-cluster-api-provider-digitalocean-conformance

@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2022

/hold for tests
/assign @fabriziopandini @timoreimann @MorrisLaw @prksu

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@timoreimann
Copy link
Contributor

/lgtm

once tests pass

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
@timoreimann
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2022

/test pull-cluster-api-provider-digitalocean-capi-e2e

@cpanato
Copy link
Member Author

cpanato commented Feb 17, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58f085b into kubernetes-sigs:main Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Feb 17, 2022
@cpanato cpanato deleted the update-flags branch February 17, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider if to align manager flag names with upstream Kubernetes components
6 participants