Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updates to controlPlaneEndpoint #334

Closed
varshavaradarajan opened this issue Apr 23, 2022 · 2 comments · Fixed by #335
Closed

Allow updates to controlPlaneEndpoint #334

varshavaradarajan opened this issue Apr 23, 2022 · 2 comments · Fixed by #335

Comments

@varshavaradarajan
Copy link
Contributor

For restore operations, it can become necessary to provision a new control plane droplet or loadbalancer. Currently, the docluster webhook prevents updates to docluster.spec.ControlPlaneEndpoint if it is not empty. We need to remove this validation to allow restores

Slack refs:
https://kubernetes.slack.com/archives/CTND9FHU2/p1644935655155549?thread_ts=1644920088.841939&cid=CTND9FHU2
https://kubernetes.slack.com/archives/CTND9FHU2/p1639149619033900?thread_ts=1639075525.031700&cid=CTND9FHU2

@cpanato - would it be possible to backport this fix to v0.5.x?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2022
@timoreimann
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants