Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add way to specify only bootstrap VM should be added to listener pool #1678

Open
hamzy opened this issue Mar 23, 2024 · 11 comments · May be fixed by #2155
Open

Add way to specify only bootstrap VM should be added to listener pool #1678

hamzy opened this issue Mar 23, 2024 · 11 comments · May be fixed by #2155
Assignees
@Karthik-K-N
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.10.0

Comments

@hamzy
Copy link

hamzy commented Mar 23, 2024

/kind feature
/area provider/ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
If we say that there should be a listener pool for port 22 , then every VM gets added to the pool In order to debug OpenShift cluster deployments, we need access to the bootstrap VM in order to get log files, etc. Because every VM is added to the pool, we cannot directly ssh into the bootstrap VM.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Mar 23, 2024
@Karthik-K-N
Copy link
Contributor

With current design we create loadbalancer and listener of loadbalancer per cluster and every machine of cluster will be attached to it.
May be for now you may need to attach all the vms to listener. We will come up with plan to support attach specific machine to specific listeners as an enhancement in later phases.

@mkumatag mkumatag added this to the Next milestone Mar 28, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 27, 2024
@mkumatag
Copy link
Member

mkumatag commented Aug 6, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 6, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 4, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 4, 2024
@Amulyam24
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 1, 2025
@mkumatag mkumatag modified the milestones: Next, v0.10.0 Jan 7, 2025
@mkumatag
Copy link
Member

mkumatag commented Jan 7, 2025

Here are few pointers we need to deal with this work item

  • API change to include that selective machines to be added into that additional listener
  • Creation, Updation, Deletion flow(what will happen when someone modifies(adds/deletes) the annotation post creation)
  • Rightnow only control plane machines are considered to be added to LB, so we need explore if you want to add any other kind of nodes to it?

Lets start writing a high level enhancement proposal for this feature, sample can be found here

@hamzy
Copy link
Author

hamzy commented Jan 7, 2025

The usecase I am specifically asking for is that I want to enforce that only the bootstrap VM will get added to the ssh port LB pool. That is an easy problem to solve. Any other ideas of improved functionality will have to come from other interested parties and should not block the implementation of this.

@Shilpa-Gokul Shilpa-Gokul linked a pull request Jan 29, 2025 that will close this issue
Open
@Karthik-K-N
Copy link
Contributor

/assign @Shilpa-Gokul

@k8s-ci-robot
Copy link
Contributor

@Karthik-K-N: GitHub didn't allow me to assign the following users: Shilpa-Gokul.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Shilpa-Gokul

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karthik-K-N Karthik-K-N

Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.10.0
6 participants
@hamzy @mkumatag @k8s-ci-robot @Amulyam24 @Karthik-K-N @k8s-triage-robot