You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We would like to request that the Fake Client library be updated from the older gopkg.in/evanphx/json-patch.v4 to github.com/evanphx/json-patch/v5.
The primary motivation for this change is to remove the indirect dependency on github.com/pkg/errors that accompanies version v4. This indirect dependency was removed in json-patch v5.9.11 and has been integrated in controller-runtime since version v0.20.2.
Rationale
Dependency Cleanup: Upgrading to v5 removes the indirect github.com/pkg/errors dependency, reducing the overall dependency footprint.
Upstream Compatibility: Aligning with newer releases ensures compatibility and support for future bug fixes and features.
Consistency: As controller-runtime is already using newer versions, matching these library versions helps maintain consistency.
Proposal
Update the import statement in pkg/client/fake/client.go from gopkg.in/evanphx/json-patch.v4 to github.com/evanphx/json-patch/v5.
Remove the direct v4 dependency entry from go.mod in favor of the v5 version, ensuring no regression in functionality.
Validate that existing tests pass and confirm there are no breaking changes.
Please let us know if you have any questions or need more details. Thank you for considering this request.
The text was updated successfully, but these errors were encountered:
We would like to request that the Fake Client library be updated from the older
gopkg.in/evanphx/json-patch.v4
togithub.com/evanphx/json-patch/v5
.The primary motivation for this change is to remove the indirect dependency on
github.com/pkg/errors
that accompanies versionv4
. This indirect dependency was removed injson-patch v5.9.11
and has been integrated in controller-runtime since versionv0.20.2
.Rationale
github.com/pkg/errors
dependency, reducing the overall dependency footprint.controller-runtime
is already using newer versions, matching these library versions helps maintain consistency.Proposal
pkg/client/fake/client.go
fromgopkg.in/evanphx/json-patch.v4
togithub.com/evanphx/json-patch/v5
.v4
dependency entry fromgo.mod
in favor of thev5
version, ensuring no regression in functionality.Please let us know if you have any questions or need more details. Thank you for considering this request.
The text was updated successfully, but these errors were encountered: