-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ControllerExpectations #644
Comments
@DirectXMan12 any opinion on this? |
Having helpers for expectations has vaguely been on the todo list. If we're going to integrate into the runtime directly, I'd like to see a rough design sketch or prototype or something before committing to a design (whatever is easiest for you) |
/kind feature |
use new scaffolding structure to support admission|conversion webhooks
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale /assign |
/kind design |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/lifecycle frozen |
There are certain use cases when controllerexpectations https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/controller_utils.go#L142 makes sense for controller logic (even though I agree they could be misused).
To hook this in properly into controller it would need to be part of the
processNextItem
so it makes sense from my point of view to be integrated into the runtime.WDYT?
The text was updated successfully, but these errors were encountered: