Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ControllerExpectations #644

Open
alenkacz opened this issue Oct 16, 2019 · 8 comments
Open

Add support for ControllerExpectations #644

alenkacz opened this issue Oct 16, 2019 · 8 comments
Assignees
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@alenkacz
Copy link
Contributor

There are certain use cases when controllerexpectations https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/controller_utils.go#L142 makes sense for controller logic (even though I agree they could be misused).

To hook this in properly into controller it would need to be part of the processNextItem so it makes sense from my point of view to be integrated into the runtime.

WDYT?

@alenkacz
Copy link
Contributor Author

@DirectXMan12 any opinion on this?

@DirectXMan12
Copy link
Contributor

Having helpers for expectations has vaguely been on the todo list. If we're going to integrate into the runtime directly, I'd like to see a rough design sketch or prototype or something before committing to a design (whatever is easiest for you)

@DirectXMan12
Copy link
Contributor

/kind feature
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Nov 5, 2019
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
use new scaffolding structure to support admission|conversion webhooks
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2020
@alenkacz
Copy link
Contributor Author

alenkacz commented Feb 4, 2020

/remove-lifecycle stale

/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2020
@vincepri vincepri added this to the Next milestone Feb 21, 2020
@vincepri
Copy link
Member

/kind design

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Feb 21, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2020
@vincepri
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants