Applier helper or apply patch type should ensure that GVK is set

[DirectXMan12]

The server-side apply logic requires that the patch have GVK set, so we should make sure that we set GVK when serializing.

[DirectXMan12]

/kind feature
/priority important-soon

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[vincepri]

/lifecycle frozen

[vincepri]

/help

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hypnoglow]

Hi,

Could you please guide how we want this to be implemented?

Would something like this suffice?

// Data implements Patch.
func (p applyPatch) Data(obj runtime.Object) ([]byte, error) {
	if obj.GetObjectKind() == nil || obj.GetObjectKind().GroupVersionKind().Empty() {
		return nil, errors.New("apply patch has no GroupVersionKind set")
	}

        // ...
}