Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace deletion in testing is not working as intended. #114

Closed
kannon92 opened this issue May 5, 2023 · 2 comments · Fixed by #115
Closed

Namespace deletion in testing is not working as intended. #114

kannon92 opened this issue May 5, 2023 · 2 comments · Fixed by #115
Assignees

Comments

@kannon92
Copy link
Contributor

kannon92 commented May 5, 2023

Generally Kubebuilder does not support deletion of namespaces. https://book.kubebuilder.io/reference/envtest.html#namespace-usage-limitation

kubernetes-sigs/controller-runtime#880

Due to this, I think we should update our tests to delete a namespace. I ran into some oddness with #101.

My proposal would be to remove the cleanup of namespaces and make sure the objects that get created are removed correctly.

@kannon92
Copy link
Contributor Author

kannon92 commented May 5, 2023

/assign

@ahg-g
Copy link
Contributor

ahg-g commented May 5, 2023

yeah, because the gc that deletes the objects is not started as part of the integration tests;

what we did with kueue was to manually delete the objects; we can do the same here: https://github.com/kubernetes-sigs/kueue/blob/main/test/util/util.go#L79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants