We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generally Kubebuilder does not support deletion of namespaces. https://book.kubebuilder.io/reference/envtest.html#namespace-usage-limitation
kubernetes-sigs/controller-runtime#880
Due to this, I think we should update our tests to delete a namespace. I ran into some oddness with #101.
My proposal would be to remove the cleanup of namespaces and make sure the objects that get created are removed correctly.
The text was updated successfully, but these errors were encountered:
/assign
Sorry, something went wrong.
yeah, because the gc that deletes the objects is not started as part of the integration tests;
what we did with kueue was to manually delete the objects; we can do the same here: https://github.com/kubernetes-sigs/kueue/blob/main/test/util/util.go#L79
kannon92
Successfully merging a pull request may close this issue.
Generally Kubebuilder does not support deletion of namespaces. https://book.kubebuilder.io/reference/envtest.html#namespace-usage-limitation
kubernetes-sigs/controller-runtime#880
Due to this, I think we should update our tests to delete a namespace. I ran into some oddness with #101.
My proposal would be to remove the cleanup of namespaces and make sure the objects that get created are removed correctly.
The text was updated successfully, but these errors were encountered: