Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karpenter_scheduler_unfinished_work_seconds is not registered with the Prometheus Registry #1994

Open
jonathan-innis opened this issue Feb 14, 2025 · 3 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jonathan-innis
Copy link
Member

Description

Observed Behavior:

The karpenter_scheduler_unfinished_work_seconds metric is never registered with the metric registry which means that we aren't emitting it from our metrics endpoint like we'd intended to

Expected Behavior:

karpenter_scheduler_unfinished_work_seconds should be properly emitted from the metrics endpoint

Reproduction Steps (Please include YAML):

karpenter git:(main) ✗ curl localhost:8080/metrics -s | grep operator | head
controller_runtime_active_workers{controller="operatorpkg.ec2nodeclass.status"} 0
controller_runtime_active_workers{controller="operatorpkg.node.status"} 0
controller_runtime_active_workers{controller="operatorpkg.nodeclaim.status"} 0
controller_runtime_active_workers{controller="operatorpkg.nodepool.status"} 0
controller_runtime_max_concurrent_reconciles{controller="operatorpkg.ec2nodeclass.status"} 10
controller_runtime_max_concurrent_reconciles{controller="operatorpkg.node.status"} 10
controller_runtime_max_concurrent_reconciles{controller="operatorpkg.nodeclaim.status"} 10
controller_runtime_max_concurrent_reconciles{controller="operatorpkg.nodepool.status"} 10
controller_runtime_reconcile_errors_total{controller="operatorpkg.ec2nodeclass.status"} 0
controller_runtime_reconcile_errors_total{controller="operatorpkg.node.status"} 0karpenter git:(main) ✗ curl localhost:8080/metrics -s | grep karpenter_scheduler_unfinished_work_seconds | head

Versions:

  • Chart Version: 1.2.1
  • Kubernetes Version (kubectl version): v1.32.2
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@jonathan-innis jonathan-innis added the kind/bug Categorizes issue or PR as related to a bug. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 14, 2025
@jonathan-innis
Copy link
Member Author

/help
/good-first-issue
/triage accepted

@k8s-ci-robot
Copy link
Contributor

@jonathan-innis:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2025
@manalilatkar
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants