Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host KWOK provider images in public ECR #1997

Open
alec-rabold opened this issue Feb 16, 2025 · 6 comments
Open

Host KWOK provider images in public ECR #1997

alec-rabold opened this issue Feb 16, 2025 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@alec-rabold
Copy link
Contributor

Description

What problem are you trying to solve?

I'm using the KWOK CloudProvider in a non-local Kubernetes cluster, which currently requires building the image manually. I noticed there's already a karpenter/kwok ECR repository here: https://gallery.ecr.aws/karpenter/kwok -- is there any chance Karpenter could host its KWOK provider there?

How important is this feature to you?

Mostly an ease-of-use improvement; happy to contribute to this!


  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@alec-rabold alec-rabold added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 16, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 16, 2025
@jonathan-innis
Copy link
Member

That strikes me as completely reasonable -- I think the only question that was left remaining is that this would have to use kubernetes-sigs resources to add this repo to an AWS account own by K8s and ensure that we use our GHA or prow to build and push changes to that repo.

I would also make sure that we callout that there's nothing "stable" about the KWOK provider (though I don't necessarily think that we need that level of guarantee) -- we often break it right now because we don't have a robust testing suite to support it

@jonathan-innis
Copy link
Member

cc: @dims or others that can help with infra resources

@jonathan-innis
Copy link
Member

/traige accepted

@jmdeal
Copy link
Member

jmdeal commented Feb 17, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 17, 2025
@alec-rabold
Copy link
Contributor Author

Nice! I'm stoked to hear that ; is there anything I can help with on my end? It sounds like there's some private infra resources that need to be set up first?

@jonathan-innis
Copy link
Member

Yeah, I'm not entirely sure on the process. I think we need to coordinate with the test-infra folks to get a prow job to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants