Ensure we use Name() consistently in our Reconcilers

[jonathan-innis]

Description

What problem are you trying to solve?

Today, we have some controllers that implement Name() and use this to inject their name in Named() call in the Register() function as well as in injecting the controller name into the context for usage in metrics with injection.WithControllerName().

Ideally, I'd like to just get rid of injection.WithControllerName() entirely -- there was a tracking issue to be able to have controller-runtime pass this into the context for us so that we don't have to do the work ourselves, but it looks like this may not get taken up: kubernetes-sigs/controller-runtime#2823

How important is this feature to you?

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[jonathan-innis]

/kind chore
/triage accepted
/help
/good-first-issue

[k8s-ci-robot]

@jonathan-innis:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind chore
/triage accepted
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

@jonathan-innis: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

/kind chore
/triage accepted
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jonathan-innis]

/kind cleanup

[Ramia1205]

Hi, @jonathan-innis! I’m interested in working on this issue. Please let me know if it’s still available, and feel free to assign it to me.

[jonathan-innis]

/assign @Ramia1205