DisruptionReason status condition isn't propagated for forceful disruptions

[jonathan-innis]

Description

Observed Behavior:

DisruptionReason status condition was added to the disruption controller to inform users of the reason that they are seeing NodeClaim disruption directly on the object. We are also planning on using this information to pass details to metric counters so that we can track things like how many pods are disrupted for a given reason

This condition was added but wasn't added to forceful disruption reasons -- which means we are going to lack information when we delete nodes due to expiration, interruption (AWS), manually terminated, etc.

We should add this reason onto forceful disruptions before we actually initiate the termination of the NodeClaim.

Expected Behavior:

All disruption reasons should cause the DisruptionReason status condition to exist on the NodeClaim

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[jonathan-innis]

/priority important-soon
/triage accepted
/help

[k8s-ci-robot]

@jonathan-innis:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/priority important-soon
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.