[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmvolod
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @dmvolod. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Welcome @dmvolod!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @dmvolod

Can you add any tests to check that this change didn't break current-version functions that will be set when the binary is released?

Hi @dmvolod

Can you add any tests to check that this change didn't break current-version functions that will be set when the binary is released?

kustomize/releasing/create-release.sh

Lines 57 to 62 in 38eb244

	CGO_ENABLED=0 GOOS=$os GOARCH=$arch go build -o output/$binary_name -ldflags\
	"-s -w\
	-X sigs.k8s.io/kustomize/api/provenance.version=$version\
	-X sigs.k8s.io/kustomize/api/provenance.gitCommit=$(git rev-parse HEAD)\
	-X sigs.k8s.io/kustomize/api/provenance.buildDate=$build_date"\
	kustomize/main.go

Hi @koba1t

It's a good point, but unfortunately it seems to not be easy until this issue golang/go#33976 will be released (golang 1.24) and info.Main.Version not populated for test. Once this will be fixed, Version will be (devel).

I will try to rewrite function which will pass whole BuildInfo to be able to test it with mock data and not only Deps info.