Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target names in Makefile to reflect support for both container engines(docker and podman) #1925

Open
ashokpariya0 opened this issue Nov 21, 2024 · 1 comment
Labels
kind/bug lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ashokpariya0
Copy link
Contributor

What happened:
Fix the target names in the Makefile (lines 113-126). The current targets are named docker-*, but we support both Docker and Podman (as seen in line 14). Therefore, the target name should be updated to reflect support for both container engines.

What you expected to happen:
The target name should be updated to reflect support for both container engines. The docker-* target is being used in various scripts across the automation and hack folders. Therefore, we need to fix the target name and also update the README and any other related files accordingly.

How to reproduce it (as minimally and precisely as possible):

Additional context:

@kubevirt-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants