Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container,build: replace hard coded docker with what is available, similarly to what we do elsewhere #1306

Open
dhiller opened this issue Oct 21, 2024 · 5 comments · May be fixed by #1352
Open

container,build: replace hard coded docker with what is available, similarly to what we do elsewhere #1306

dhiller opened this issue Oct 21, 2024 · 5 comments · May be fixed by #1352
Labels
good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/buildsystem Denotes an issue or PR that relates to changes in the build system.

Comments

@dhiller
Copy link
Contributor

dhiller commented Oct 21, 2024

Is your feature request related to a problem? Please describe:

We currently build kubevirtci images using docker, we should use whatever image build system is available instead.

Example:

kubevirtci/cluster-provision/centos9/build.sh

Line 7 in cde64d6

docker build --build-arg centos_version=$centos_version . -t quay.io/kubevirtci/centos9

Describe the solution you'd like:

In general we have solution(s) available that figure out what platforms are present and depending on what the user prefers. We should apply that logic to the hard coded parts that are remaining.

Example of a good solution: https://github.com/kubevirt/kubevirt/blob/35b53a7f687e1b7c53eb1476337aef36807e7402/hack/common.sh#L11

Describe alternatives you've considered:
None

Additional context:
/help

Ping @brianmcarey or @dhiller for further information about this.
@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as needing help from a contributor.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Is your feature request related to a problem? Please describe:

We currently build kubevirtci images using docker, we should use whatever image build system is available instead.

Example:

kubevirtci/cluster-provision/centos9/build.sh

Line 7 in cde64d6

docker build --build-arg centos_version=$centos_version . -t quay.io/kubevirtci/centos9

Describe the solution you'd like:

In general we have solution(s) available that figure out what platforms are present and depending on what the user prefers. We should apply that logic to the hard coded parts that are remaining.

Example of a good solution: https://github.com/kubevirt/kubevirt/blob/35b53a7f687e1b7c53eb1476337aef36807e7402/hack/common.sh#L11

Describe alternatives you've considered:
None

Additional context:
/help

Ping @brianmcarey or @dhiller for further information about this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the help wanted Identifies an issue that has been specifically created or selected for new contributors. label Oct 21, 2024
@dosubot dosubot bot added the sig/buildsystem Denotes an issue or PR that relates to changes in the build system. label Oct 21, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Oct 21, 2024

/good-first-issue

@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as suitable for new contributors.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the good first issue Identifies an issue that has been specifically created or selected for first-time contributors. label Oct 21, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2025
@Saumya40-codes Saumya40-codes linked a pull request Jan 20, 2025 that will close this issue
Open
8 tasks
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Identifies an issue that has been specifically created or selected for first-time contributors. help wanted Identifies an issue that has been specifically created or selected for new contributors. kind/enhancement lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/buildsystem Denotes an issue or PR that relates to changes in the build system.
Projects
None yet
Milestone
No milestone
2 participants
@dhiller @kubevirt-bot