release-tool: fix config-forking #3958
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
dco-signoff: yes
| @@ -457,3 +460,37 @@ func TestNewTag(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func Test_convertRunBeforeMergeToAlwaysRun(t *testing.T) { | |||
There was a problem hiding this comment.
As said in another PR, since this is a non-exported function the IDE would not find it. Also it's more clear and less annoying to read (IMHO) - but if you insist...
There was a problem hiding this comment.
^^ this is what I mean
dhiller
force-pushed
the
fix-release-tool-config-fork
branch
3 times, most recently
from
6a9cf87 to
4e2135e
Compare
|
@xpivarc renamed test func, PTAL, thanks! |
config-forking was broken in a couple of ways: * it used an old version of the config-forker from test-infra which didn't retain the value for `run_before_merge` * it didn't update the forked config, since for release branches the phase plugin didn't work in the same way, therefore the values had to be converted from run_before_merge to to always_run We also now use this opportunity to remove the bazel cache label since we need to do that every time anyways: kubevirt#3961 This commit fixes the issues. Signed-off-by: Daniel Hiller <[email protected]>
dhiller
force-pushed
the
fix-release-tool-config-fork
branch
from
4e2135e to
4db3d2e
Compare
|
@xpivarc updated PR, PTAL, thank you! |
What this PR does / why we need it:
config-forking was broken in a couple of ways:
run_before_mergerun_before_mergetoalways_runThis PR fixes the issues.
We also now use this opportunity to remove the bazel cache label since
we need to do that every time anyways: #3961
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3478
Special notes for your reviewer:
/cc @xpivarc @enp0s3