Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix,test-label-analyzer: move glue code from job into stats #3964

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Feb 19, 2025

What this PR does / why we need it:

This PR fixes the quarantined test report generation, which was broken since the changes wrt prow dependencies.

Changes:

  • Integrates the auto-determination of the latest commit id from the test
    repository into the test repository url.
  • Adds the capability to write the report directly to a gcs bucket.
  • Updates the job configuration to reflect the added flags.

Successful rehearse run: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirt-quarantined-tests-daily-report/1892152494935511040

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3925

Special notes for your reviewer:

/cc @brianmcarey

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 19, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhiller dhiller force-pushed the fix-test-label-analyzer branch from 108bcae to 51c9467 Compare February 19, 2025 10:04
@dhiller dhiller changed the title fix,test-label-analyzer: auto-insert git commit id fix,test-label-analyzer: move glue code in job into test-label-analyzer Feb 19, 2025
@dhiller dhiller changed the title fix,test-label-analyzer: move glue code in job into test-label-analyzer fix,test-label-analyzer: move glue code into test-label-analyzer Feb 19, 2025
@dhiller dhiller changed the title fix,test-label-analyzer: move glue code into test-label-analyzer fix,test-label-analyzer: move glue code from job into stats Feb 19, 2025
@dhiller dhiller marked this pull request as ready for review February 19, 2025 10:10
@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 19, 2025
Integrates the auto-determination of the latest commit id from the test
repository into the test repository url.

Signed-off-by: Daniel Hiller <[email protected]>
Adds the capability to write the report directly to a gcs bucket.

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller dhiller force-pushed the fix-test-label-analyzer branch from 51c9467 to d8182b4 Compare February 20, 2025 12:39
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-label-analyzer: add uploading to target gcs bucket
2 participants