Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failing on check PIE Full RELRO on aarch64 #51

Open
viferga opened this issue Feb 27, 2025 · 0 comments
Open

CI failing on check PIE Full RELRO on aarch64 #51

viferga opened this issue Feb 27, 2025 · 0 comments

Comments

@viferga
Copy link

viferga commented Feb 27, 2025

I just tried to run the tests: https://github.com/metacall/plthook/actions/runs/13563427213/job/37911073715
and I got this error:

------------ check PIE Full RELRO ------------
make run_tests "CFLAGS_EXE=-fPIE -pie" "EXTRA_CFLAGS=-Wl,-z,relro,-z,now"
make[1]: Entering directory '/home/runner/work/plthook/plthook/test'
rm -f libtest.so testprog
aarch64-linux-gnu-gcc -shared -fPIC -Wall -Wl,-z,relro,-z,now -O3 -DLIBTEST_DLL -o libtest.so libtest.c -lm
aarch64-linux-gnu-gcc -fPIE -pie -Wall -Wl,-z,relro,-z,now -O3 -o testprog -I.. testprog.c ../plthook_elf.c -L. -ltest -ldl -lm
testprog.c: In function ‘strtod_cdecl_hook_func’:
testprog.c:93:5: warning: ‘__builtin_strncpy’ specified bound 30 equals destination size [-Wstringop-truncation]
   93 |     strncpy(hv->str, str, sizeof(hv->str));
      |     ^
testprog.c: In function ‘strtod_hook_func’:
testprog.c:93:5: warning: ‘__builtin_strncpy’ specified bound 30 equals destination size [-Wstringop-truncation]
LD_LIBRARY_PATH=. qemu-aarch64 -L /usr/aarch64-linux-gnu ./testprog open
success
LD_LIBRARY_PATH=. qemu-aarch64 -L /usr/aarch64-linux-gnu ./testprog open_by_handle
success
test "" || env LD_LIBRARY_PATH=. qemu-aarch64 -L /usr/aarch64-linux-gnu ./testprog open_by_address
success
make[1]: Leaving directory '/home/runner/work/plthook/plthook/test'
------------ check Partial RELRO + -fno-plt ------------
make[1]: Entering directory '/home/runner/work/plthook/plthook/test'
rm -f libtest.so testprog
aarch64-linux-gnu-gcc -shared -fPIC -Wall -Wl,-z,relro -fno-plt -O3 -DLIBTEST_DLL -o libtest.so libtest.c -lm
aarch64-linux-gnu-gcc  -Wall -Wl,-z,relro -fno-plt -O3 -o testprog -I.. testprog.c ../plthook_elf.c -L. -ltest -ldl -lm
testprog.c: In function ‘strtod_cdecl_hook_func’:
testprog.c:93:5: warning: ‘__builtin_strncpy’ specified bound 30 equals destination size [-Wstringop-truncation]
   93 |     strncpy(hv->str, str, sizeof(hv->str));
      |     ^
testprog.c: In function ‘strtod_hook_func’:
testprog.c:93:5: warning: ‘__builtin_strncpy’ specified bound 30 equals destination size [-Wstringop-truncation]
LD_LIBRARY_PATH=. qemu-aarch64 -L /usr/aarch64-linux-gnu ./testprog open
Error: ['3.7', 3.700000, 3.700000] ['', 0.000000] ['3.7', 3.700000] at line 327
make[1]: *** [Makefile:67: run_tests] Error 1
make[1]: Leaving directory '/home/runner/work/plthook/plthook/test'
make: *** [Makefile:88: relro_pie_tests] Error 2

@kubo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant