Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #14

Open
elfring opened this issue Apr 18, 2016 · 1 comment
Open

reserved identifier violation #14

elfring opened this issue Apr 18, 2016 · 1 comment
Labels

Comments

@elfring
Copy link

elfring commented Apr 18, 2016

I would like to point out that identifiers like "__BGMApp__BGMPlayThrough__" and "__BGMDriver__BGM_Client__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@kyleneideck
Copy link
Owner

Hi, thanks for pointing this out. I'll update them when I get a chance (unless someone else feels like doing it).

If I'm reading the page you linked right, I think the sample code BGMDriver is based on also makes this mistake and so do the Core Audio Public Utility Classes. Should somebody file a radar? (I don't really know C++, so I'm not sure how serious this mistake is.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants