Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular imports #1

Open
millette opened this issue May 31, 2024 · 0 comments
Open

Circular imports #1

millette opened this issue May 31, 2024 · 0 comments

Comments

@millette
Copy link

First of, thanks for the package. I've not had a change to try it but it's on my short list.

I was going over the code when I noticed engine.ts and bktree.ts import each other.

Would you accept a PR extracting damerauLevenshteinDistance and DistanceCache to a separate file? At first glance, I think that would break (fix) the cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant