Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap additional functions in scico.scipy.special #166

Closed
Michael-T-McCann opened this issue Jan 10, 2022 · 3 comments
Closed

Wrap additional functions in scico.scipy.special #166

Michael-T-McCann opened this issue Jan 10, 2022 · 3 comments
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies priority: low Low priority

Comments

@Michael-T-McCann
Copy link
Contributor

(Adapted from a TODO left in the code.) We currently do not wrap lpmn or lpmn_values because they take integers as their first argument and ndarray as their last argument, and this does not work with the current _block_array_ufunc_wrapper.

@Michael-T-McCann Michael-T-McCann added the priority: low Low priority label Jan 10, 2022
@bwohlberg bwohlberg added enhancement New feature or request improvement Improvement of existing code, including addressing of omissions or inconsistencies and removed enhancement New feature or request labels Jan 11, 2022
@bwohlberg
Copy link
Collaborator

@Michael-T-McCann: Was this perhaps resolved in #259?

@Michael-T-McCann
Copy link
Contributor Author

@Michael-T-McCann: Was this perhaps resolved in #259?

This is not resolved; these still aren't wrapped. However, I vote to close on the basis that I don't think the goal here should be to wrap every conceivable function, but rather to wrap the functions that somebody wants to use with block arrays.

@bwohlberg
Copy link
Collaborator

Fair enough. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing code, including addressing of omissions or inconsistencies priority: low Low priority
Projects
None yet
Development

No branches or pull requests

2 participants