Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with compressibility limit in new Gruneisen EOS #332

Open
jhp-lanl opened this issue Jan 4, 2024 · 0 comments
Open

Deal with compressibility limit in new Gruneisen EOS #332

jhp-lanl opened this issue Jan 4, 2024 · 0 comments
Assignees
Labels
discussion enhancement New feature or request Robustness Ensures that existing features work as intended

Comments

@jhp-lanl
Copy link
Collaborator

jhp-lanl commented Jan 4, 2024

From #331 :

I think it would be good to compute a maximum density for this EOS to ensure that sound speeds aren't imaginary.

You can see we used this approach in the other Gruneisen EOS, but with a much more complicated procedure for calculating the maximum density (since it's a cubic Us-up fit).

I would recommend mirroring this approach where the user is allowed to provide a maximum density or not. If the maximum density is used, then we set it and perhaps warn the user if it's greater than the singularity in the denominator of the Hugoniot expression. If the user does not provide a maximum density, then we provide one based off of the Hugoniot fit parameter.

See this section of the other Gruneisen EOS for an example of how to do this.

Gruneisen(const Real C0, const Real s1, const Real s2, const Real s3, const Real G0,

Originally posted by @jhp-lanl in #331 (review)

@Yurlungur Yurlungur self-assigned this Jan 4, 2024
@jhp-lanl jhp-lanl added enhancement New feature or request discussion labels Jan 4, 2024
@Yurlungur Yurlungur added the Robustness Ensures that existing features work as intended label Jan 4, 2024
@jhp-lanl jhp-lanl mentioned this issue Jan 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request Robustness Ensures that existing features work as intended
Projects
None yet
Development

No branches or pull requests

4 participants