Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thread lambdas through the get_sg_eos code #467

Open
Yurlungur opened this issue Feb 13, 2025 · 1 comment
Open

thread lambdas through the get_sg_eos code #467

Yurlungur opened this issue Feb 13, 2025 · 1 comment
Labels
bug Something isn't working clean-up Changes that don't affect code execution but make the code cleaner enhancement New feature or request

Comments

@Yurlungur
Copy link
Collaborator

The get_sg_eos code currently does not have the ability to thread lambdas through. For things like partial ionization this will be required. Also, in get_sg_eos_rho_p, @dholladay00 pointed out that in in this case cache[0] may not be properly indexed for the case where nmat != npte.
@Yurlungur Yurlungur added bug Something isn't working enhancement New feature or request clean-up Changes that don't affect code execution but make the code cleaner labels Feb 13, 2025
@Yurlungur Yurlungur mentioned this issue Feb 13, 2025
Merged
9 tasks
@Yurlungur
Copy link
Collaborator Author

The issue is potentially more serious, actually. In the case when nmat != npte, all of the indexing in the pure cell case might be off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working clean-up Changes that don't affect code execution but make the code cleaner enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yurlungur