Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and review error messages #160

Open
jjcollinge opened this issue Jul 27, 2018 · 0 comments
Open

Clean up and review error messages #160

jjcollinge opened this issue Jul 27, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@jjcollinge
Copy link
Collaborator

jjcollinge commented Jul 27, 2018

There are multiple places where errors have context added at multiple layers that are obsolete. We should review the current logging and clean up any messages where this is the case. An example would be: mongodb.go func: NewMongoDB() - the underlying mgo will raise a detailed error to do with the connection, this function then adds the context "can't connect to mongo, go error..." then the callers of this function add additional context such as "failed initialising mongo connection", resulting in the error message:

failed initialising mongo connection: can't connect to mongo, go error: host unreachable which could be simplified to Kubernetes provider failed to initialise a connection to MongoDB: host unreachable

There are multiple occurrences such as this throughout the code base.

@jjcollinge jjcollinge added the enhancement New feature or request label Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant