Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logo enlarges on return to the home page. #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abbi4code
Copy link

Notes for Reviewers

This PR fixes #222

##Fixes

  • Added an id attribute to the navbar logo image with the value navbar-brand_logo.
  • Updated the JavaScript to check if the clicked image is the navbar logo.
  • If the image has the ID navbar-brand_logo, the modal will not open.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 1a3faa8
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66cc6fe208104d0008e8695c
😎 Deploy Preview https://deploy-preview-355--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ashparshp Ashparshp self-requested a review August 29, 2024 07:16
@Ashparshp
Copy link
Contributor

@abbi4code, Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Logo pops as bigger icon when we redirect back to home page
2 participants