carousel #435
carousel #435
Conversation
Signed-off-by: GitHub <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -3,6 +3,7 @@ title: "Local video 1" | |||
| description: "Birth of Kanvas logo from Meshery Birth of Kanvas logo from Meshery" | |||
| src: "/videos/pattern-import.mp4" | |||
| videoType: local | |||
| video_id: "Do7htKrRzdA" | |||
There was a problem hiding this comment.
Between src and video_id, while both are valid frontmatter details, one can be considered optional, so that as the other one is provided. A video page must have one of the two; can use either one of the two.
The only time that video_id or src is necessary is when you want to embed a video on a docs page inline with the reading. In that case, we can use a shortcode to display the video inline, right? For YouTube, it's the current shortcode and for video on the file system that would be a different shortcode? ({{< youtube and {{local-video).
Otherwise, the src field and video_id field are unnecessary considering that videos are generally to be displayed based on their assigned categories and tags.
Notes for Reviewers
This PR fixes #432
Signed commits