Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change Lake configuration error message #6829

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: change Lake configuration error message #6829

wants to merge 3 commits into from

Conversation

BoltonBailey
Copy link
Contributor

@BoltonBailey BoltonBailey commented Jan 28, 2025 •
edited
Loading

This PR changes the error message for Lake configuration failure to reflect that issues do not always arise from an invalid lakefile, but sometimes arise from other issues like network errors. The new error message encompasses all of these possibilities.

Closes #6827

@BoltonBailey BoltonBailey requested a review from tydeu as a code owner January 28, 2025 21:36
@BoltonBailey BoltonBailey changed the title change error message chore: change Lake configuration error message Jan 28, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 28, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 28, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9f5a9a071a7dd8d81c590308f5cb036280beaf06 --onto 20c616503abe5ce4253c56dbcd7766a91c675ba0. (2025-01-28 22:04:13)
  • 🟡 Mathlib branch lean-pr-testing-6829 build against this PR was cancelled. (2025-01-28 23:20:44) View Log
  • ✅ Mathlib branch lean-pr-testing-6829 has successfully built against this PR. (2025-01-29 00:05:47) View Log

@BoltonBailey BoltonBailey force-pushed the BoltonBailey/lake-workpace-error-msg branch from f544d33 to c639b2d Compare January 28, 2025 22:20
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6829
338c407
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6829
e4d1c4c
@BoltonBailey
Copy link
Contributor Author

I would add the error message label, but I don't seems to have permission to.

@tydeu tydeu added the changelog-lake Lake label Jan 28, 2025
@tydeu
Copy link
Member

tydeu commented Jan 28, 2025

No worries! Thanks for doing this!

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6829
c47231a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 28, 2025
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#6829
d3e2888
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message for "Invalid Lake configuration" appears for non-config related errors
3 participants
@BoltonBailey @leanprover-community-bot @tydeu