Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounty process UI adjustments #10

Open
3 tasks done
troggy opened this issue Jun 16, 2020 · 3 comments
Open
3 tasks done

Bounty process UI adjustments #10

troggy opened this issue Jun 16, 2020 · 3 comments

Comments

@troggy
Copy link
Member

troggy commented Jun 16, 2020

Bounty

Scope

  • add "checkbox" to hide incoming "change txs" from BountyPayout (they are created with every payout and noisy). Make the checkbox active by default.
  • allow creating bounty payouts even if there is not enough balance in the wallet (requested by @johannbarbie as a WhiteRabbit keybearer)

Deliverables

  • updated and deployed Safe frontend

Funding Circle

General Circle

Bounty Owner/Gardener

@troggy as Process Engineer

Gain for the Role

less hiccups for Keybearers

Roles

bounty gardener: @troggy / 20 DAI
bounty worker: @troggy / 85%
bounty reviewer: [reviewer] / 15%

Gardener checklist

@johannbarbie
Copy link
Member

allow creating bounty payouts even if there is not enough balance in the wallet

thanks for putting this is. i thought about this more, and have 2 open questions:

  • if the transactions fail, they can't be rerun later in safe. Would there need to be a warning or something like that for the user before executing?
  • also, transactions that are not executed block laters transactions. could an underfunded pending bounty payout block another transaction that is more important?

@troggy
Copy link
Member Author

troggy commented Jun 16, 2020

Would there need to be a warning or something like that for the user before executing?

yes, we can have warning. Also we should actually check if the Safe have enough balance at execution time and prevent execution if not.

@troggy
Copy link
Member Author

troggy commented Jun 16, 2020

could an underfunded pending bounty payout block another transaction that is more important?

yes, it will block all the other txs. I remember Gnosis' guys mentioned they are working on something to get around this (safe-global/safe-smart-account#199)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants