-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the canvas file to Devtools on compile #51
Comments
flutter/flutter#92134 This PR was supposed to solve our problem. It seems that this was introduced on Flutter 2.10.0 but we just recently updated Flutter on our repositories. I'm checking if we are using the proper version of flutter when building the web folder. EDITThis PR only introduced a cache for the canvaskit file. This does not solve our problem. It seems that the only way to solve this issue is to use an environment variable on |
So according to the discussion int the PR #74, this is an issue that flutter could fix in the future. For now there is a workaround that could break anytime if flutter change the way canvaskit is handled. @taorepoara should we apply the workaround for now or should we just wait until Flutter provide a "native" fix ? |
Check Flutter V3 and fix for this version if not implemented natively |
@lenra-io/devs Does someone remember how to replicate this issue locally ? I tried to launch the devtools while offline, it seems to be working. |
I had the problem when I was offline and using the devtool Docker image. I can try to see if the problem remains. |
Reproduced with incognito window. |
According to this comment on a Flutter issue flutter/flutter#60069 (comment), canvaskit is bundled with the app when you run |
It seems that the |
Accoriding to the post you linked, the fonts are not working out of the box. But if we follow the link in your comment, we have this : flutter/flutter#60069 (comment) We should probably wait until it's officially done instead of workaround... What do you think @jonas-martinez ? @taorepoara ? |
In my opinion we might not absolutely need this feature. We can wait for Flutter to do the fix on their side, which was planned for Q1 2022 so it might come soon. |
Add the Canvas file https://unpkg.com/[email protected]/bin/canvaskit.js, on compile to allow work offline
The text was updated successfully, but these errors were encountered: