Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent changelog: empty or not (random) #354

Open
slorber opened this issue Jul 29, 2020 · 6 comments
Open

inconsistent changelog: empty or not (random) #354

slorber opened this issue Jul 29, 2020 · 6 comments

Comments

@slorber
Copy link

slorber commented Jul 29, 2020

Hi,

I'm working on docusaurus. We are long-time lerna-changelog users.

I noticed that Lerna gives me unpredictable changelogs.

A command can give me an empty changelog, and 10 seconds later, the exact same command gives me the changelog I want:

image

As I'm not able to enable verbose logging or whatever, I don't really know what is happening.

I noticed that when the changelog is empty, the last % of the progress bar takes much longer just before.

Also noticed that running lerna-changelog --from lastReleaseTag is much faster than just lerna-changelog, and much more likely to give me a non-empty output. Basically, I feel

Has anyone an idea about what is going on?

I tried to delete the .changelog generated folder to see if it improves, but not really. Maybe there's some rate-limiting happening and errors are swallowed or something?

The repo is public and my token has the correct permissions, afaik:

image

@slorber slorber changed the title Empty changelog inconsistent changelog: randomly empty Jul 29, 2020
@Turbo87
Copy link
Contributor

Turbo87 commented Jul 29, 2020

hmm, thanks for reporting this. I haven't noticed any such issues so far unfortunately

As I'm not able to enable verbose logging or whatever, I don't really know what is happening.

yeah, I guess we could/should introduce something like https://github.com/visionmedia/debug to enable verbose logging if such things happen 🤔

@slorber slorber changed the title inconsistent changelog: randomly empty inconsistent changelog: empty or not (random) Jul 29, 2020
@slorber
Copy link
Author

slorber commented Jul 29, 2020

Yes that could be helpful.

For example, just logging which tag it uses when I don't provide --from attribute would be nice

@slorber
Copy link
Author

slorber commented Aug 1, 2020

FYI I tried with a new Github token and it didn't work better :'(

@izelnakri
Copy link

izelnakri commented Dec 6, 2020

@Turbo87 I have the sample problem, lerna-changelog shows the progress bar and then silently fails(succeeds) without creating a CHANGELOG, lerna-changelog --from lastReleaseTag doesnt help either, it silently fails on all cases. You can try it here, we should probably make lerna-changelog more strict so it never fails silently.

https://github.com/izelnakri/memserver [having the CHANGELOG or not having has no impact on the command output, tried that as well]

@Turbo87
Copy link
Contributor

Turbo87 commented Dec 6, 2020

@izelnakri the PRs in your project don't have any labels, which is why they don't show up in the generated changelog. see https://github.com/lerna/lerna-changelog#usage

@izelnakri
Copy link

izelnakri commented Dec 6, 2020

Yes, I just realized that after an hour of debugging 🤦 Added an explanation PR here: #391

Initially I thought it autogenerates a label for each commit by default if missing, my assumption was wrong 😄 It would be nice I think if we build some 'AI' like logic to generate changelog per PR if its missing label :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants