Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limactl stop kills child processes on Windows preventing shutdown sequence #3221

Open
arixmkii opened this issue Feb 11, 2025 · 0 comments
Open

Comments

@arixmkii
Copy link
Contributor

Description

Some time ago I reported similar issue with CTRL-C command for containers #1284 This was fixed by decoupling long living HA into independent console host (new process group).

Then SIGINT to this process was implemented via sending CTRL-C through syscalls

return windows.GenerateConsoleCtrlEvent(syscall.CTRL_BREAK_EVENT, uint32(pid))

The problem is that it has QEMU VM and potentially SSH master (this requires additional testing) attached withing the same process group and it will immediately kill QEMU.

It causes a lot of error logs, sometimes results in ERROR CODE 130 from limactl stop and with QEMU it causes data loss for virtual hdd changes not flushed.

Possible solutions:

  1. start QEMU in new process group on Windows
  2. use qemu-system-x86_64w.exe (w here is for Windows GUI like process, which is automatically detached from console host)

This manifests in integration tests "restart" scenario. File is lost.

I can work on implementation, when decision is made on the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants