Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'high' severity package used 'medium' delay for migration #32

Open
JonathonHall-Purism opened this issue Sep 22, 2023 · 1 comment
Open
Labels
incomplete Issue is waiting for further information

Comments

@JonathonHall-Purism
Copy link

gnome-settings-daemon 44.1-1pureos2 was published with severity 'high' in landing, but the migration status says that it needs to be 5 days old to migrate. I expected it to be 2 days, since that's the delay configured for 'high'; 5 is for 'medium'.

The migration is currently here (screenshot below): https://master.pureos.net/migrations/excuse/63dd9edc-520d-4075-bc56-544f2e349bb4

Here's the config where I think 'high' should be 2 days: https://source.puri.sm/pureos/infra/pureos-laniakea-config/-/blob/main/config/spears-tasks.toml

Changelog with 'high' priority for 44.1-1pureos2: https://source.puri.sm/Librem5/debs/gnome-settings-daemon/-/blob/pureos/latest/debian/changelog

Screenshot of migration:
Screenshot_20230922_093252

@ximion
Copy link
Member

ximion commented Sep 24, 2023

I've looked through the code, and I see no way how this could possibly be happening...
Laniakea reads the Urgency field of a changes file, and if none exists, assumed low as priority. Since this upload has medium priority one of two things must have happened:

  • The changes_urgency property could not have been set at all (in which we assume medium by default)
  • The changes file did contain medium for its Urgency field, even though the changelog contained high

When a package is accepted, there is only one codepath this can take, in which the changes_urgency is overridden unconditionally. So, at the moment I assume the reason for this is the second one, which wouldn't make it a Laniakea issue, but a builder issue. How was this package built?

I think at the moment we can only keep this bug report open and monitor the situation, and see if this happens again (potentially adding more logging if needed).

@ximion ximion added the incomplete Issue is waiting for further information label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete Issue is waiting for further information
Projects
None yet
Development

No branches or pull requests

2 participants