Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit insertion point being restored by an InsertionGuard in buildSwitchBody() #665

Open
bcardosolopes opened this issue Jun 6, 2024 · 1 comment

Comments

@bcardosolopes
Copy link
Member

          These tests are failing because the insertion point is restored by an InsertionGuard in `buildSwitchBody()`. I suggest revising that part after #528 is merged to avoid conflict.

} else if (lastCaseBlock) {
// This means it's a random stmt following up a case, just
// emit it as part of previous known case.
mlir::OpBuilder::InsertionGuard guardCase(builder);
builder.setInsertionPointToEnd(lastCaseBlock);
res = buildStmt(c, /*useCurrentScope=*/!isa<CompoundStmt>(c));
} else {

Originally posted by @piggynl in #611 (comment)

@bcardosolopes
Copy link
Member Author

@piggynl somehow I cannot assign this issue to you, but here's an issue to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant