Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach op parsers to use enum keyword parsing helpers #770

Open
seven-mile opened this issue Aug 3, 2024 · 1 comment
Open

Teach op parsers to use enum keyword parsing helpers #770

seven-mile opened this issue Aug 3, 2024 · 1 comment
Assignees
@chansuke
Labels
good first issue Good for newcomers

Comments

@seven-mile
Copy link
Collaborator

Similar to LLVM dialect, we have enum keyword parsing helpers like parseOptionalCIRKeyword and parseCIRKeyword. We should reuse them to implement existing enum parsing logic, e.g. function visibility and switch case kind.

Originally posted by @bcardosolopes in #760 (comment)
@bcardosolopes bcardosolopes added the good first issue Good for newcomers label Aug 6, 2024
@chansuke
Copy link

Hello. I am new to Clang IR and am interested in working on this issue.
Could you please assign it to me? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chansuke chansuke

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chansuke @bcardosolopes @seven-mile