Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker is blind to changes in multi-line strings #2

Open
johncarney opened this issue Nov 30, 2017 · 0 comments
Open

Checker is blind to changes in multi-line strings #2

johncarney opened this issue Nov 30, 2017 · 0 comments

Comments

@johncarney
Copy link
Contributor

johncarney commented Nov 30, 2017

Currently the checker only considers changes on key lines, meaning it will overlook changes in multi-line strings.

Possible solutions

We could modify LocaleFileKeyMap#key_at so it returns the nearest key preceding the given line, and consider all changed non-comment lines when examining the diffs. I can see some potential issues with this in how deletions are handled.

I think a more robust solution is to use git diff to identify changed files, but do all the change analysis by loading the old (ie. origin/master) and new versions of the changed files and hash-diffing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant