Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: type metadata.chromaSubsampling as union with undefined #4190

Closed
DavidVaness opened this issue Aug 14, 2024 · 1 comment
Closed

Bug: type metadata.chromaSubsampling as union with undefined #4190

DavidVaness opened this issue Aug 14, 2024 · 1 comment

Comments

@DavidVaness
Copy link
Contributor

DavidVaness commented Aug 14, 2024

Hey @lovell,
thanks for the great work on sharp

Right now chromaSubsampling is typed as required.

chromaSubsampling: string;

Given that all metadata values are a union with undefined, I think this one has been overlooked and needs to be changed to

chromaSubsampling?: string | undefined;

I have created a PR to update the type here
#4191

Feel free to close / delete the PR if the type was correct ✌🏼

@lovell
Copy link
Owner

lovell commented Aug 16, 2024

v0.33.5 now available, thanks for the PR.

@lovell lovell closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants