We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hey @lovell, thanks for the great work on sharp
Right now chromaSubsampling is typed as required.
sharp/lib/index.d.ts
Line 1072 in 2474bd4
Given that all metadata values are a union with undefined, I think this one has been overlooked and needs to be changed to
chromaSubsampling?: string | undefined;
I have created a PR to update the type here #4191
Feel free to close / delete the PR if the type was correct ✌🏼
The text was updated successfully, but these errors were encountered:
v0.33.5 now available, thanks for the PR.
Sorry, something went wrong.
No branches or pull requests
Hey @lovell,
thanks for the great work on sharp
Right now chromaSubsampling is typed as required.
sharp/lib/index.d.ts
Line 1072 in 2474bd4
Given that all metadata values are a union with undefined, I think this one has been overlooked and needs to be changed to
I have created a PR to update the type here
#4191
Feel free to close / delete the PR if the type was correct ✌🏼
The text was updated successfully, but these errors were encountered: