-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some texts don't have translations #1152
Comments
While going on testing, we also discovered that the translations are missing on the specified file: |
You may as well update them when doing your translation PR. |
Ok! Perfect! We were worried about the conventions relative to the keys in the translation files, but we'll try our best to match the standards! We will keep writing here where we spot issues just to keep track and then close the issue along with the PR we are going to open. |
While testing for Italian translation me and @sebhd1 noticed that most of the texts in
packages/admin/resources/views/partials/forms/discount.blade.php
are not using__()
so there are no related entries in translation files.The text was updated successfully, but these errors were encountered: