-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling A additionals and out-of-order results, so that the correct IP address can be parsed #33
base: master
Are you sure you want to change the base?
Conversation
@mafintosh what do you think? This looks good to me |
…ing up result parsing or multicast-dns results
I restarted my computer today and started getting some unexpected behavior again today... so back to investigating I go. I found that there is some conflict between multicast-dns results and node-ssdp results. The results parsed from node-ssdp seem to do everything "correctly", as in it gets to correct friendly name and correct host IP. The results parsed from multicast-dns can sometimes do one of two things wrong: it may get a weird id name (i.e. This seems to introduce some race conditions. I found that I may get only 2 results (expected for my network), I may get 3 results (with one device repeating, but internally having 2 different names so appearing as 2 devices), or get 4 results with both of my devices repeating. I attempted to clean all this up, resolve differences between multicast-dns and node-ssdp, and make sure that there are no device duplicates and both host and friendly name are parsed with the correct priority from the results, regardless of order. Though I have updated this branch (and this PR), it's significantly different from the first implementation, so please let me know if you prefer a different PR (I personally prefer keeping the history and conversation in one place, so I am opting to update this PR). |
@Ivshti The PR is already up to date with the latest code I have that I have been using for a little over a week now in one of my active projects. It is ready for a review. |
Any progress on this? |
this addressed #32