-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue] Cleanup: don't use void return value from method calls. #882
Open
2 of 5 tasks
Labels
Comments
6 tasks
magento-ct-gh-projects-svc
added
Progress: PR created
Progress: ready for grooming
and removed
Progress: PR created
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: PR created
and removed
Progress: PR created
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: ready for grooming
and removed
Progress: PR created
Progress: ready for grooming
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: ready for grooming
and removed
Progress: ready for grooming
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: ready for grooming
and removed
Progress: PR created
Progress: ready for grooming
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: PR created
and removed
Progress: ready for grooming
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: ready for grooming
and removed
Progress: ready for grooming
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
added
Progress: PR created
and removed
Progress: PR created
Progress: ready for grooming
labels
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Pull Request In Progress
to Ready for Grooming
in Backlog
Jan 21, 2025
magento-ct-gh-projects-svc
moved this from Ready for Grooming
to Pull Request In Progress
in Backlog
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is automatically created based on existing pull request: #881: Cleanup: don't use void return value from method calls.
Description (*)
This is just some minor cleanup. We called a method that didn't return anything (void) and then used that result value. Which is really not needed.
Found issue while running phpstan on level 0 on the entire codebase:
This is my ongoing effort on getting the entire Magento codebase clean so running phpstan on level 0 no longer gives any errors anymore (after this PR, we have about ~440 issues to go still ...)
Also see this related PR: magento/magento2#39516
Story
?
Bug
?
Task
?
Fixed Issues (if relevant)
N/A
Builds
?
Related Pull Requests
magento/magento2#39516
Manual testing scenarios (*)
ext/magento/magento2-page-builder/
directory only, as running it on the entire Magento codebase might take a very long time (multiple hours sometimes, depending on how strong your machine is) ...Questions or comments
Check the first commit to see the real changes, the second commit deals with fixing static test failures.
Checklist
The text was updated successfully, but these errors were encountered: