-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to mapnik 3.0.13 mason package for travis builds #143
Comments
Started this in https://github.com/mapnik/python-mapnik/tree/stable-upstream-3.0.13, however I'm blocked on:
@artemp can you please either:
|
@springmeyer - there is already https://github.com/mapnik/python-mapnik/tree/v3.0.x |
According to https://tools.ietf.org/html/rfc7946#section-3.1.1 :
"coordinates": [ [ [ [] ] ] ] The above is a valid JSON but not valid GeoJSON (as per spec ^) /cc @springmeyer |
@artemp okay, so do the test expectations need updated? If so, can you push the correct update to master and the v3.0.x branch? |
@springmeyer - ^ yes! This issue surfaced in I'm going to make some changes to make handling empty geometries more consistent, because following GeoJSON should also throw invalid dataset exception:
|
I'm working on this PR mapnik/mapnik#3643 |
Original issue solved in #144 |
mapbox/mason#365 is available now in mason. Next step is to point the python-mapnik builds at it. The goal here is to move to testing python-mapnik
master
against a stable mapnik version (rather than a moving target)./cc @artemp @flippmoke
The text was updated successfully, but these errors were encountered: