Replies: 2 comments 1 reply
-
We have both #485 and #2765 for a Web-UI and Code-Review integration, which we're probably going to base off Sapling's ISL. |
Beta Was this translation helpful? Give feedback.
-
May I say noice on both features they are both awesome and can't wait to see both of them implemented! But what I was thinking more was like an integration to do the code review locally, which may or may not be covered in the WebUI issue above. It doesn't look covered from what I'm seeing there, but maybe I don't know enough. What I was thinking is something along the lines:
Again, I'm wondering if it's a good ideea. What I don't like about it is that it's duplicating a bit on what the GitHub/Gerrit etc do and that it sounds complex. On the other hand if I don't have this I usually write a quick and dirty script to at least iterate through the files on a fast pace, because I don't like the flow of checking in the code review tool then copy pasting in the IDE/opening my favorite diff viewer to see the change, if I need to check something on it. |
Beta Was this translation helpful? Give feedback.
-
TLDR: I'm wondering on this if a code review feature should/could/is wise to be added to jj. Or if anybody knows of some extensions that can do that (either for jj or git for that matter)
On my side whenever I have to do a code review I did a bunch of scripts to help out with the task, which essentially do a diff with the main branch (well with the most recent common ancestor to be exact) and lunch my IDE on said file and a diff tool on each file. The process continues to the next file whenever I close the diff tool. Right now I'm a bit lazy to migrate these tools to
I couldn't find any tools to help me out with this especially for seeing the diff and switching into the IDE etc.
I'm wondering if it would not be wiser to have something backed in the SCM which would help you out with this also allowing you to mark some changes as reviewed.
A lot of ideas pop into my head on this like:
Disclaimer: I really liked the sapling integration where it can fetch you detailed info about the PR status of a branch/commit, but I know that comes with some performance downsides and I know that is far from what I'm suggesting here.
Also this looks like a really complex implementation, but it should provide quite a few benefits in term of how one can develop and code review.
Beta Was this translation helpful? Give feedback.
All reactions