Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Unignore and enforce check E203 ("Whitespace before colon") #9368

Closed
ShadowJonathan opened this issue Feb 10, 2021 · 2 comments
Closed

Unignore and enforce check E203 ("Whitespace before colon") #9368

ShadowJonathan opened this issue Feb 10, 2021 · 2 comments

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Feb 10, 2021

(E203 checks "Whitespace before ':' ")

According to setup.cfg, E203 is partly ignored because it's 'contrary to PEP8'. After a bit of research i found out that it is due to colons in slice indexes, which is covered under PEP8.

Going down the rabbithole a bit further, I found PyCQA/pycodestyle#373 and PyCQA/pycodestyle#914, so I suggest tracking those issues and removing E203 once these are resolved, merged, and shipped.

@ShadowJonathan ShadowJonathan changed the title Unignore and enforce check E203 (after colon-in-index edge-case has been solved) Unignore and enforce check E203 ( Feb 10, 2021
@ShadowJonathan ShadowJonathan changed the title Unignore and enforce check E203 ( Unignore and enforce check E203 ("Whitespace before colon") Feb 10, 2021
@clokep
Copy link
Member

clokep commented Feb 10, 2021

This sounds more like we'd just let black handle where to put that whitespace and not really worry about flake8 here?

@erikjohnston
Copy link
Member

Yup, it feels like black is covering this case and so we can safely turn off the flake8 checking of it. I don't think its worth digging into if that's the case

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants