Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

migrate to a node.js action #21

Open
maxheld83 opened this issue Aug 14, 2019 · 4 comments
Open

migrate to a node.js action #21

maxheld83 opened this issue Aug 14, 2019 · 4 comments

Comments

@maxheld83
Copy link
Owner

maybe this can be a "host" aka "js" action?

Doesn't seem like this would really need a docker container.

@maxheld83
Copy link
Owner Author

maxheld83 commented Aug 14, 2019

asked support whether they were planning on doing this anyway.

@kayvanbree
Copy link

Right now it doesn't work for yml. It gives the following error:

error: src refspec @github.com/<user>/<repo>.git does not match any.

That was after using this config:

on: push
name: Build and publish
jobs:
  install:
    name: Install
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@master
    - name: Install
      uses: actions/npm@59b64a598378f31e49cb76f27d6f3312b582f680
      with:
        args: install
    - name: Build
      uses: actions/npm@59b64a598378f31e49cb76f27d6f3312b582f680
      with:
        args: run build --prod
    - name: Deploy to GitHub Pages
      uses: maxheld83/[email protected]
      env:
        BUILD_DIR : dist/f10k
        GH_PAT: ${{ secrets.GH_PAT }}

I don't know if this is useful. I'm new to actions, but they changed it that this action can't run on the new format, right?

@alex-page
Copy link
Contributor

alex-page commented Sep 14, 2019

@maxheld83 I made my own repository for now using JS. If you are interested in moving to JS I would be happy to close my action and create some pull requests:

https://github.com/alex-page/blazing-fast-gh-pages-deploy

@maxheld83 maxheld83 changed the title upgrade for yml-based GitHub actions migrate to a node.js action Sep 24, 2019
@maxheld83
Copy link
Owner Author

maxheld83 commented Sep 24, 2019

@alex-page sorry for taking so long. Yes, that would be amazing, I'd love to join forces on this!

It seems to me that this really ought to be a JS action, not a container action – so please, PR away!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants