Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Migrate to a JavaScript action #23

Closed
wants to merge 14 commits into from
Closed

Migrate to a JavaScript action #23

wants to merge 14 commits into from

Conversation

alex-page
Copy link
Contributor

@alex-page alex-page commented Sep 25, 2019

Some initial work to get this moving to JavaScript. I haven't had time to test this out.

This fixes #21 I also see it as a good opportunity to update the documentation for to fix #22

Remaining work:

  • Testing
  • If you are running this action inside an organization or user repository (named username/username.github.io) it will deploy to the master branch instead.
  • Documentation updates
  • New screenshots

Thoughts

  • This is a breaking change, suggested v1.0.0
  • I have tried to keep the code as close to the original shell script in entrypoint.sh
  • I tweaked some of the language in the README.md to remove bias.

Any feedback is welcome, thanks!

@alex-page alex-page changed the title Migrate to JavaScript action Migrate to a JavaScript action Sep 25, 2019
@maxheld83 maxheld83 self-requested a review September 25, 2019 07:36
@maxheld83
Copy link
Owner

this is amazing, thanks so much @alex-page. I'm a bit swamped until next Monday, but will address this asap.

@alex-page
Copy link
Contributor Author

alex-page commented Jan 18, 2020

@maxheld83 I don't have the bandwidth for this right now 😞 .

There is a problem with running git commit -m and I haven't been able to find the time to debug this. For now I am closing this PR but feel free to reopen it if someone else wants to pick it up.

@alex-page alex-page closed this Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document minimum required scope for PAT migrate to a node.js action
2 participants