fix(windows): improve process termination and port cleanup #1151
+253
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
maybe can you share screen recording to show it works in different conditions? biggest issue is when updating windows app and then have to reboot because of this issue sometimes ... |
Signed-off-by: David Anyatonwu <[email protected]>
onyedikachi-david
force-pushed
the
fix/windows-process-termination-11949
branch
from
48226a1 to
abcd845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Implements robust process management for Windows to fix issues with processes not being properly terminated and ports remaining in use. This PR introduces a new
ProcessManagerthat uses Windows Job Objects to ensure proper cleanup of processes and port releases.Fixes: #1149