Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local graphiql front-end sources for offline development #1063

Open
mikaelkaron opened this issue Dec 19, 2023 · 1 comment
Open

local graphiql front-end sources for offline development #1063

mikaelkaron opened this issue Dec 19, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mikaelkaron
Copy link
Contributor

at the moment graphiql loads all of it's front-end resource from unpkg - this works fine if you are online while developing, but is less than ideal when offline.

these are the sources loaded from unpkg:

'https://unpkg.com/[email protected]/umd/react.production.min.js',
'https://unpkg.com/[email protected]/umd/react-dom.production.min.js',
'https://unpkg.com/[email protected]/graphiql.min.js'

related: platformatic/platformatic#1944
@mcollina
Copy link
Collaborator

the reason I’ve implemented it in this way is to keep the package from npm small, and avoid a complex build step.

I think the best idea would be to split it into another package, similarly to what we did for fastify-swagger-ui.

@mcollina mcollina added enhancement New feature or request good first issue Good for newcomers labels Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @mikaelkaron