Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15, 30 and 45 minutes alignement #112

Open
JolinM opened this issue Jan 20, 2021 · 6 comments
Open

15, 30 and 45 minutes alignement #112

JolinM opened this issue Jan 20, 2021 · 6 comments

Comments

@JolinM
Copy link

JolinM commented Jan 20, 2021

Describe the bug
15, 30 and 45 minutes aren’t neatly aligned.

Expected behavior
To respect the same angle as a clock

Screenshots

Capture d’écran, le 2021-01-20 à 13 48 03

Desktop (please complete the following information):

  • OS version: macOS 11.1
  • Version 1.6.0

Love the app by the way, so useful!

@robinstewart
Copy link
Contributor

This is a side effect of making sure that small, common increments of time at the beginning are easier to select — 10 seconds, 20 seconds... 1 min, 2 min... up to 5 min, which is significantly past where it would be on a clock. Then minutes 5 through 60 are fit into the remaining space.

Maybe a reasonable fix would be to fit minutes 5 through 30 into the remaining space up to the "6-o-clock" position and then continue at normal clock spacing from there.

@JolinM
Copy link
Author

JolinM commented Jan 20, 2021

Oh, it totally make sense then!

Maybe a reasonable fix would be to fit minutes 5 through 30 into the remaining space up to the "6-o-clock" position and then continue at normal clock spacing from there.

That seems like an interesting compromise. Could work well. Otherwise, just keep it as is; it’s nothing that shocking ;)

@karbassi
Copy link
Collaborator

@robinstewart, i think that's a good idea. If you're up for it, I'll review the PR.

@JolinM
Copy link
Author

JolinM commented Jan 21, 2021

What is PR…?

@karbassi
Copy link
Collaborator

karbassi commented Jan 21, 2021

@JolinM, sorry for using tech jargon.

PR stands for Pull Request.

Here's a quick video explaining it. https://www.youtube.com/watch?v=2VX1ISk9XH8

@MaxPower85
Copy link

This is a side effect of making sure that small, common increments of time at the beginning are easier to select — 10 seconds, 20 seconds... 1 min, 2 min... up to 5 min, which is significantly past where it would be on a clock. Then minutes 5 through 60 are fit into the remaining space.

Maybe a reasonable fix would be to fit minutes 5 through 30 into the remaining space up to the "6-o-clock" position and then continue at normal clock spacing from there.

That doesn't sound like some "Mac-like solution" to me 😄 I mean, Apple generally seems to try to design the interface how someone expects it to work and if 5 or 10 or 30 minutes weren't where someone expected them to be on a clock, that would seem kind of unexpected... also the original Minutes widget didn't do that... 5 minutes was at the equal distance from the center as 55 minutes was on the other side... but it only allowed you to set minutes...

If you wanted to set seconds, I think it would be better to just have a separate mode for seconds... maybe just add one small button in the corner (it could be just a letter M that changes to S when you click on it) to change to a mode for seconds and use the whole circle for seconds then... but I'm not really sure how much someone really needs to set a reminder that will appear in like 10-20 seconds in everyday life, when someone isn't just setting it to test it quickly... so I think the option to set the seconds isn't really necessary and that the design should be more focused on how much is something needed in everyday use.

BTW... I think it would look nicer if that "arrow" was larger... it looks like there's just too much empty space around that circle with such a small "arrow"... and if there were buttons for additional options in corners like on the Minutes widget (it had a button to loop the timer and a button to switch between modes it which it rings or plays a song from iTunes in another mode or opens some file in some other mode)... I also think having a standard close button with a red circle that's always there looks somewhat distracting and I think it would be better if it maybe only appeared on the corner as a larger "X" in a gray circle when you press Alt like in Dashboard or to just quit it from the Menu bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants